BUG: Add min/max methods to ArrowExtensionArray GH#61311 #61924
Merged
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Jul 22, 2025
|
@mroeschke Thank you for your suggestion. I will rework on this PR to implement the _validate_key fix instead. |
simonjayhawkins
added
Bug
Indexing
skonda29
force-pushed
the
skonda29-issue-61311
branch
from
117175b to
f87de21
Compare
|
@mroeschke Would you mind taking a look at this PR when you get a chance? I've added a conversion to NumPy in _validate_key, and included a test case. Feedback is appreciated! |
mroeschke
reviewed
Jul 30, 2025
pandas/core/indexing.py
Outdated
Comment on lines
1613
to
1617
| # convert to numpy array for min/max with ExtensionArrays | ||
| if hasattr(arr, "to_numpy"): | ||
| np_arr = arr.to_numpy() | ||
| else: | ||
| np_arr = np.asarray(arr) |
There was a problem hiding this comment.
Check if arr is an ExtensionArray using if isinstance(arr.dtype, ExtensionDtype) and use arr._reduce("max") instead
mroeschke
reviewed
Jul 30, 2025
pandas/tests/indexing/test_iloc.py
Outdated
|
|
||
| df_arrow = df.convert_dtypes(dtype_backend="pyarrow") | ||
| result = df_arrow.iloc[:, df_arrow["c"]] | ||
| expected = df_arrow.iloc[:, [0, 2]] |
There was a problem hiding this comment.
Construct this using DataFrame(...) instead
|
@mroeschke Please take a look at this implementation. I've implemented your suggestions |
mroeschke
reviewed
Aug 5, 2025
mroeschke
approved these changes
Aug 5, 2025
|
Thanks @skonda29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ArrowExtensionArray' object has no attribute 'max'when passing pyarrow-backed series to.iloc#61311doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The core problem is that when using .iloc with PyArrow-backed DataFrames, pandas' indexing validation calls min() and max() methods on the ArrowExtensionArray for bounds checking, but these methods were not implemented, resulting in AttributeError: 'ArrowExtensionArray' object has no attribute 'max'. This breaks basic indexing functionality that works with regular pandas DataFrames, creating an inconsistency in the PyArrow backend experience.
Proposed Solution -
My proposed solution addresses the issue by modifying _validate_key in pandas/core/indexing.py to detect ExtensionArrays and convert them to numpy arrays using to_numpy() or np.asarray(). Included a test case in the file pandas/tests/indexing/test_iloc.py that reproduces the issue to verify the implementation.